helm/pkg
Matthew Fisher 8d408876a0
Fix race condition in `helm list` (#4620)
* Fix race in helm list when partitioning

Problem:
The chunks slice that is passed through the channel is reused for each
partition. This means that encoding the release into a message is racing with
populating the next partition, causing the results to sometimes not fit in the
message, and the release list to be incorrect

Solution:
Allocate a new slice for each partition

Issue #3322

Signed-off-by: Brian Marshall <bmarshall13@users.noreply.github.com>
(cherry picked from commit a0858e29d8)

* fix import sorting

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* ref(release_server_test): use NewReleaseServer()

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add unit test for race condition in `helm list`

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
(cherry picked from commit 5b23632446)
2018-09-10 11:19:58 -07:00
..
chartutil Fix helm create note for k8 label convention changes 2018-08-24 16:17:41 +01:00
downloader Updating to the k8s label convention 2018-08-08 12:21:38 -04:00
engine Merge pull request #4221 from cmattoon/issue-2347 2018-08-31 17:29:26 -07:00
getter Set proxy for all connections, fixes #4326 (#4579) 2018-09-03 06:57:41 -07:00
helm allow settings TLS flags from environment variables (#4590) 2018-09-07 13:23:40 -07:00
hooks change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
ignore change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
kube ref(*): kubernetes v1.11 support 2018-08-09 19:13:12 -07:00
lint Merge pull request #4221 from cmattoon/issue-2347 2018-08-31 17:29:26 -07:00
manifest [manifests] hoist the regex out of SplitManifests 2018-08-06 17:24:02 -07:00
plugin change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
proto/hapi feat(helm): add ability to sort release list by chart name 2018-09-01 05:40:07 -04:00
provenance change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
releasetesting change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
releaseutil feat(helm): add ability to sort release list by chart name 2018-09-01 05:40:07 -04:00
renderutil [templates] extract some rendering code into a package 2018-08-06 17:24:02 -07:00
repo Only propagate query string if refURL is relative to baseURL 2018-08-06 18:25:02 -05:00
resolver change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
rudder change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
storage Avoid importing k8s.io/kubernetes from pkg/helm (#4499) 2018-09-04 11:19:33 -07:00
strvals Fix typo in parser.go 2018-08-17 09:34:59 -05:00
sympath change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
tiller Fix race condition in `helm list` (#4620) 2018-09-10 11:19:58 -07:00
timeconv change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
tlsutil fix(helm): fix(helm): add `--tls-hostname` flag to tls flags 2018-08-07 16:56:40 -07:00
urlutil change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
version bump version to v2.11 2018-09-07 13:48:05 -07:00