Commit Graph

8 Commits

Author SHA1 Message Date
JoeWrightss 9e18364fea Fix some spelling errors in comment (#5246)
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-01-31 21:33:04 -08:00
Matthew Fisher 5b23632446
Fix race condition in `helm list` (#4620)
* Fix race in helm list when partitioning

Problem:
The chunks slice that is passed through the channel is reused for each
partition. This means that encoding the release into a message is racing with
populating the next partition, causing the results to sometimes not fit in the
message, and the release list to be incorrect

Solution:
Allocate a new slice for each partition

Issue #3322

Signed-off-by: Brian Marshall <bmarshall13@users.noreply.github.com>
(cherry picked from commit a0858e29d8)

* fix import sorting

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* ref(release_server_test): use NewReleaseServer()

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add unit test for race condition in `helm list`

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
2018-09-10 11:14:03 -07:00
Arash Deshmeh 380ca1a923 feat(helm): add ability to sort release list by chart name
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-09-01 05:40:07 -04:00
Matthew Fisher 2d77db11fa change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
fibonacci1729 ad99c1b749 release list paritioning 2018-04-02 15:43:47 -06:00
fibonacci1729 2dd9b34d28 stream releases when listing 2018-03-28 15:43:31 -06:00
Adam Reese eccb041c0f
ref(tiller): cleanup goimports 2017-06-12 10:30:21 -07:00
fibonacci1729 a4d05fd2b2 ref(tiller): refactor tiller APIs into logical files
*ReleaseServer.UninstallRelease -> tiller/release_uninstall.go
*ReleaseServer.ListReleases -> tiller/release_list.go
2017-05-22 11:37:55 -06:00