Commit Graph

15 Commits

Author SHA1 Message Date
Flavian 69c7ba320e Fix: type conversion for zero values (#5151)
* added test for zero values

Signed-off-by: Flavian <flavian.sierk@gmail.com>

* implemented case for zero values

Signed-off-by: Flavian <flavian.sierk@gmail.com>
2019-02-01 08:12:46 -08:00
Dan Winter e23793120b fix(helm): --set for out of order list values (#4682)
When a user specifies value overrides for list values out of order,
strvals.listItem panics. Change strvals.listItem to handle this case by
re-initializing nil values to a new map.

Closes #4503

Co-authored-by: Cameron Childress <cameron@cchildress.org>
Co-authored-by: Kevin Collette <hal.collette@gmail.com>
Co-authored-by: Connor McKelvey <connormckelvey@gmail.com>
Co-authored-by: Dan Winter <dan.j.winter@gmail.com>

Signed-off-by: Dan Winter <dan.j.winter@gmail.com>
Signed-off-by: Cameron Childress <cameron@cchildress.org>
Signed-off-by: Kevin Collette <hal.collette@gmail.com>
Signed-off-by: Connor McKelvey <connormckelvey@gmail.com>
2018-11-19 17:58:25 +01:00
Jon Huhn d929391199
Fix typo in parser.go 2018-08-17 09:34:59 -05:00
Matthew Fisher 2d77db11fa change copyright to "Copyright The Helm Authors" 2018-07-30 08:29:17 -07:00
KUOKA Yusuke dc93908626 feat: Set values from local files (#3758)
Adds the `--set-file key=filepath` flag to `install`, `upgrade`, `template` and `lint` sub-commands so that the content of the file at the `filepath` is set to the value for the `key`.

Resolves #1754
2018-07-25 15:12:40 -06:00
Elmar Ritsch 272d9bc6ef Parse booleans and null as string values with --set-string flag 2018-05-29 21:17:37 +02:00
Matthew Fisher f7f686f7d0
Revert "toYaml - Fix #3470 and #3410's trailing \n issues" 2018-04-27 12:30:46 -07:00
Michelle Noorali 1850aeade9 fix(pkg/strvals): evaluate "null" values
resolves #3891
Co-authored-by: Matthew Fisher <matt.fisher@microsoft.com>
2018-04-17 16:23:29 -04:00
Erik Sundell 6cdf6cee56 toYaml - Fixes #3470 - trailing \n issue
`toYaml` was introducing a new line. It is an issue since the new line is part of a functions output, it can't be whitespace chomped away so it would require a `trimSuffix "\n"` pipe. This commit trims one trailing `\n` from the toYaml output.
2018-04-06 00:58:54 +02:00
adshmh 1a55161a53 Fix several golint warnings (#3756)
* fix(helm): fix golint warning due to ApiVersionV1 constant name

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix golint warning due to ResolveChartVersionAndGetRepo comment

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix golint warnings on HttpGetter type and SetCredentials method missing a comment

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm):fix golint warning due to comment on FindChartInAuthRepoURL function

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix golint warning due to RepoFile type name

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix golint warning due to ParseString comment

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-03-27 13:06:04 -07:00
Arturo Contreras a615f80c92 Adding --set-string flag to force string values. 2018-03-20 13:35:42 -06:00
Sam Leavens a5dc546726 fix(pkg/strvals): use rune literal instead of ASCII
When checking that a value begins with zero use a rune literal instead of the
ASCII code for zero.
2017-07-27 11:32:10 -07:00
Sam Leavens 609e72b357 fix(pkg/strvals): preserve leading zeros in vals
When passing values with "helm install --set" values with leading zeros are
preserved and not parsed as ints.

Closes #2693
2017-07-26 17:16:39 -07:00
Matt Butcher c01c7318ab
feat(helm): support array index format for --set.
This adds support for specifying list position with an array index using
`--set`. For example, this now works: `--set servers[0].port=8080`
2017-06-08 12:15:03 -06:00
Matthew Fisher 1aee50f5db move pkg cmd/helm/strvals to pkg/strvals
This is another useful package outside of cmd/helm.
2017-03-09 14:05:33 -08:00